chore: updated to Theia 1.35.0
#1976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
added
topic: code
3 tasks
added 4 commits
April 11, 2023 10:44
Signed-off-by: Akos Kitta <[email protected]>
Closes arduino#1501 Upstream: eclipse-theia/theia#12354 Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
per1234
reviewed
Apr 11, 2023
There was a problem hiding this comment.
I know Akos is already aware, but I'll add a note here for transparency:
There was a hypothesis this update might have allowed us to avoid the GLibC dependency that is causing builds of the IDE on a machine with a newer Ubuntu version (e.g., the ubuntu-latest GitHub Actions runner has Ubuntu 22.04) to fail to start on machines with an older version of GLibC, as discussed at #1983 and #259.
I tried starting the build of this PR (created on the ubuntu-latest runner) on a Ubuntu 18.04 machine and encountered the same problem as discussed in #1983:
Error: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_arduinlmTF8J/resources/app/node_modules/nsfw/build/Release/nsfw.node)
at process.func [as dlopen] (node:electron/js2c/asar_bundle:5:1800)
at Object.Module._extensions..node (node:internal/modules/cjs/loader:1170:18)
at Object.func [as .node] (node:electron/js2c/asar_bundle:5:1800)
at Module.load (node:internal/modules/cjs/loader:982:32)
at Module._load (node:internal/modules/cjs/loader:823:12)
at Function.c._load (node:electron/js2c/asar_bundle:5:13331)
at Module.require (node:internal/modules/cjs/loader:1006:19)
at require (node:internal/modules/cjs/helpers:93:18)
at Object.<anonymous> (/tmp/.mount_arduinlmTF8J/resources/app/node_modules/nsfw/js/src/index.js:4:14)
at Module._compile (node:internal/modules/cjs/loader:1110:14) {
code: 'ERR_DLOPEN_FAILED'
}
4 tasks
|
Replaced by #2027. Closing as invalid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Change description
Closes #1501
readonly_1501.mp4
Other information
Reviewer checklist